Fall25 - M3 Milestone - r1.1 - version v0.1.0 Release Candidate by chinaunicomyangfan · Pull Request #14 · camaraproject/SubscriptionStatus

chinaunicomyangfan · 2025-06-27T18:03:16Z

What type of PR is this?

Add one of the following kinds:

subproject management

What this PR does / why we need it:

This PR implements the scope
The PR updates all the file in terms of release number referring to r1.1 and version v0.1.0-rc.1
CHANGELOG.MD, README.MD & Readiness check list updated version are provide

Which issue(s) this PR fixes:

Fixes #12

Changelog input

 release-note

CHANGELOG.MD

Added

CHANGELOG.MD

code/Test_definitions/subscription-status.feature

ToshiWakayama-KDDI · 2025-07-04T02:23:14Z

Hi @chinaunicomyangfan ,

I have just found that the yaml file has two 403 errors, KNOW_YOUR_CUSTOMER.ID_DOCUMENT_REQUIRED and KNOW_YOUR_CUSTOMER.ID_DOCUMENT_MISMATCH, but I believe these two errors are not relevant to SubscriptionStatus API because ID Document parameters are not used. Could you recheck it?

Thanks,
Toshi

CHANGELOG.MD

Kevsy

@chinaunicomyangfan thanks for the PR!

Please can you check my review comments/suggestions for:

CHANGELOG.MD
README.MD
subscription-status-API- Readiness-Checklist
subscription-status.feature

Please note you will also need to change the subscription-status.yaml:

XCorrelator needs to be a schema object , see camaraproject/Commonalities#480

Kevsy · 2025-07-08T10:58:51Z

@chinaunicomyangfan thanks for the PR!

Please can you check my review comments/suggestions for:

CHANGELOG.MD

README.MD

subscription-status-API- Readiness-Checklist

subscription-status.feature

Please note you will also need to change the subscription-status.yaml:

XCorrelator needs to be a schema object , see camaraproject/Commonalities#480

Hi @chinaunicomyangfan , please can you provide the updates? I will not be able to complete the release management review until the fixes are made. Thanks!

chinaunicomyangfan · 2025-07-09T02:05:25Z

@chinaunicomyangfan thanks for the PR!
Please can you check my review comments/suggestions for:

CHANGELOG.MD

README.MD

subscription-status-API- Readiness-Checklist

subscription-status.feature

Please note you will also need to change the subscription-status.yaml:

XCorrelator needs to be a schema object , see camaraproject/Commonalities#480

Hi @chinaunicomyangfan , please can you provide the updates? I will not be able to complete the release management review until the fixes are made. Thanks!

@Kevsy Thanks a lot for your suggestion, I totally approve.
I have update the XCorrelator schema in c637c91.
Please review the update.

code/API_definitions/subscription-status.yaml

Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>

Kevsy · 2025-07-11T10:57:22Z

Thanks for the updates @chinaunicomyangfan !

One more change is required:

Add the mandatory Authorization and authentication text into the info.description section of subscription-status.yaml

Add the mandatory Authorization and authentication text

chinaunicomyangfan · 2025-07-14T09:19:37Z

Thanks for the updates @chinaunicomyangfan !

One more change is required:

Add the mandatory Authorization and authentication text into the info.description section of subscription-status.yaml

yaml has been updated , please review

hdamker

Two minor comments

hdamker · 2025-07-14T09:25:51Z

CHANGELOG.MD

+The below sections record the changes for each API version in each release as follows:
+
+* for an alpha release, the delta with respect to the previous release
+* for the first release-candidate, all changes since the last public release
+* for subsequent release-candidate(s), only the delta to the previous release-candidate
+* for a public release, the consolidated changes since the previous public release
+The below sections record the changes for each API version in each release as follows:
+
+* for an alpha release, the delta with respect to the previous release
+* for the first release-candidate, all changes since the last public release
+* for subsequent release-candidate(s), only the delta to the previous release-candidate
+* for a public release, the consolidated changes since the previous public release


Duplication, please remove one instance

code/Test_definitions/subscription-status.feature

Delete duplication

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

chinaunicomyangfan · 2025-07-15T01:13:52Z

Two minor comments

Thanks, @hdamker ,done, please review.

hdamker · 2025-07-15T05:02:13Z

Thanks, @hdamker ,done, please review.

My comments are addressed, thanks. Overall review from ReleaseManagement is with @Kevsy

Kevsy · 2025-07-15T15:17:55Z

@chinaunicomyangfan just one small change to make:

Please can you add a description to the /retrive-subscription-status path in subscription-status.yaml ?

Add description to the /retrive-subscription-status path

chinaunicomyangfan · 2025-07-21T03:04:06Z

the /retrive-subscription-status path

@Kevsy Description added, please review,thanks.

Kevsy · 2025-07-21T08:38:01Z

code/API_definitions/subscription-status.yaml

      tags:
        - Retrive Subscription Status
+      description: |
+        Oobtain the business subscription status of the provided phone number, including Voice/SMS inbound, Voice/SMS outbound, and data service status.


Suggested change

Oobtain the business subscription status of the provided phone number, including Voice/SMS inbound, Voice/SMS outbound, and data service status.

Obtain the business subscription status of the provided phone number, including Voice/SMS inbound, Voice/SMS outbound, and data service status.

Thanks,done

Kevsy

Thanks @chinaunicomyangfan - now approved on behalf of release management.

Next steps for the codeowners:

PR merged (by API repository codeowner)
Release created within GitHub (by API repository codeowner)
Release Tracker updated (with creation date of the release and the release tag link)

ChuanyuChen

looks good to me

chinaunicomyangfan added 11 commits June 28, 2025 01:34

Create CHANGELOG.MD

352ef81

Update CHANGELOG.MD

12e246b

Update CHANGELOG.MD

5934d90

Create subscription-status-API-Readiness-Checklist.md

b193dec

Update release candidate version number

68ddbf0

Update subscription-status.feature rc version number

1fb5c32

Delete code/Test_definitions/README.md

99fab3a

Delete code/API_definitions/README.MD

2452381

Delete documentation/API_documentation/README.MD

9ae0de0

Update README.md

76adb26

Update README.md

9032ffa

chinaunicomyangfan requested review from a team, ChuanyuChen, ClownsAlbert and DanXu-ChinaTelecom as code owners June 27, 2025 18:03

chinaunicomyangfan added the Fall25 label Jun 27, 2025

hdamker mentioned this pull request Jun 29, 2025

SubscriptionStatus r1.1 (Fall25 M3, new API) release review camaraproject/ReleaseManagement#249

Closed

26 tasks

Kevsy reviewed Jul 3, 2025

View reviewed changes

CHANGELOG.MD Show resolved Hide resolved

fix: added text from the release management template CHANGELOG.md

b0d3df0

Added

Kevsy reviewed Jul 3, 2025

View reviewed changes

CHANGELOG.MD Outdated Show resolved Hide resolved

fix: added -rc.1 to Commonalities version

9e33bc6

Kevsy reviewed Jul 3, 2025

View reviewed changes

CHANGELOG.MD Outdated Show resolved Hide resolved

fix: added -rc.1 to ICM version

abf0e00

Kevsy reviewed Jul 3, 2025

View reviewed changes

code/Test_definitions/subscription-status.feature Outdated Show resolved Hide resolved

fix: corrected version syntax

399fb33

Kevsy reviewed Jul 4, 2025

View reviewed changes

CHANGELOG.MD Outdated Show resolved Hide resolved

Removed mention of 'implementation code'

bda42f4

Kevsy reviewed Jul 4, 2025

View reviewed changes

CHANGELOG.MD Outdated Show resolved Hide resolved

Reformatted 'what's changed' into preferred headings

bb96d12

Kevsy requested changes Jul 4, 2025

View reviewed changes

Update XCorrelator schema in yaml file

c637c91

Merge branch 'camaraproject:main' into Fall25-M3

cc032ce

Kevsy reviewed Jul 10, 2025

View reviewed changes

code/API_definitions/subscription-status.yaml Outdated Show resolved Hide resolved

chinaunicomyangfan and others added 7 commits July 11, 2025 09:42

Apply suggestions from code review

3078238

Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>

Apply suggestions from code review

148f327

Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>

Apply suggestions from code review

5aab16a

Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>

Apply suggestions from code review

b256767

Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>

Apply suggestions from code review

dc41b4f

Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>

Apply suggestions from code review

b543f39

Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>

Apply suggestions from code review

5bca4c2

Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>

Add the mandatory Authorization and authentication text

9ed579e

Add the mandatory Authorization and authentication text

hdamker reviewed Jul 14, 2025

View reviewed changes

chinaunicomyangfan and others added 2 commits July 15, 2025 09:12

Update CHANGELOG.MD

de57394

Delete duplication

Update code/Test_definitions/subscription-status.feature

f1a1df0

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Add description to the /retrive-subscription-status path

459c115

Add description to the /retrive-subscription-status path

Kevsy reviewed Jul 21, 2025

View reviewed changes

Update subscription-status.yaml

89d55ce

Kevsy approved these changes Jul 21, 2025

View reviewed changes

ChuanyuChen approved these changes Jul 22, 2025

View reviewed changes

chinaunicomyangfan merged commit 1c9f0da into camaraproject:main Jul 22, 2025
2 checks passed

chinaunicomyangfan deleted the Fall25-M3 branch March 2, 2026 08:02

	Oobtain the business subscription status of the provided phone number, including Voice/SMS inbound, Voice/SMS outbound, and data service status.
	Obtain the business subscription status of the provided phone number, including Voice/SMS inbound, Voice/SMS outbound, and data service status.

Conversation

chinaunicomyangfan commented Jun 27, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Changelog input

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ToshiWakayama-KDDI commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kevsy left a comment

Choose a reason for hiding this comment

Uh oh!

Kevsy commented Jul 8, 2025

Uh oh!

chinaunicomyangfan commented Jul 9, 2025

Uh oh!

Uh oh!

Kevsy commented Jul 11, 2025

Uh oh!

chinaunicomyangfan commented Jul 14, 2025

Uh oh!

hdamker left a comment

Choose a reason for hiding this comment

Uh oh!

hdamker Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chinaunicomyangfan commented Jul 15, 2025

Uh oh!

hdamker commented Jul 15, 2025

Uh oh!

Kevsy commented Jul 15, 2025

Uh oh!

chinaunicomyangfan commented Jul 21, 2025

Uh oh!

Kevsy Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

chinaunicomyangfan Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

Kevsy left a comment • edited by chinaunicomyangfan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ChuanyuChen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ToshiWakayama-KDDI commented Jul 4, 2025 •

edited

Loading

hdamker Jul 14, 2025 •

edited

Loading

Kevsy left a comment •

edited by chinaunicomyangfan

Loading